Skip to content

split verify-gen into multiple targets in pre-push pre-commit hook #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

split verify-gen into multiple targets in pre-push pre-commit hook #5374

merged 1 commit into from
Jan 23, 2025
+83 −64

Conversation

@nawazkh
Copy link
Member

@nawazkh nawazkh commented Jan 17, 2025 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • I found that splitting make verify-gen into two targets is helping with swap file accumulation that was slowing down pre-push stage.
  • Without this change, upon running pre-push stage locally, the swap file was increasing to 56GB and the pre-push stage ran for 52 mins. 😢

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##5318

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@nawazkh
split verify gen into multiple targets
79bf648 
This addresses swap file increase issue.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2025
@codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.44%. Comparing base (8b8ba05) to head (79bf648).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5374   +/-   ##
=======================================
  Coverage   52.44%   52.44%           
=======================================
  Files         272      272           
  Lines       29349    29349           
=======================================
  Hits        15391    15391           
  Misses      13152    13152           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

willie-yao

This comment was marked as duplicate.

Sign in to view

willie-yao
willie-yao reviewed Jan 17, 2025
View reviewed changes
.pre-commit-config.yaml
entry: make go-test
language: system
stages: [pre-push]
- repo: https://github.com/gitleaks/gitleaks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the extra indent here intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editor changes.. Unintentional. But doesn't harm ? I can remove the indentation if you'd like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, it was just a bit hard for me to visualize the diff, but doesn't have to be changed.

willie-yao
willie-yao approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51c6a806489e81dc8a7478ebc12de9144588888c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit fdf5a9c into kubernetes-sigs:main Jan 23, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 23, 2025
@nawazkh nawazkh deleted the update-pre-commit branch April 4, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willie-yao willie-yao willie-yao approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@willie-yao willie-yao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

3 participants

@nawazkh @k8s-ci-robot @willie-yao